-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape "|" in Table.create_table #63
Conversation
Please can you rebase didix21:master? |
I'm wondering why you have to scape '|'? |
Table columns are seperated by |, if the list of strings contains |, the table will be malformed. If it is in the header row, the table is shown as raw text. If it is in the body row, the last cell of the row is ignored. I dont expect this behavior, i think i should be a bug. |
Btw, what about \n? It should be the same case. I faced this when I am handling articles' titles, i submit this pr immediately, didnt think quite much beyond that... |
Wait a sec, i will do that |
Seems tests are not running after the rebase. Let me close pull request and open it again. |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 13 13
Lines 462 462
Branches 81 81
=======================================
Hits 395 395
Misses 45 45
Partials 22 22
Continue to review full report at Codecov.
|
Thanks, have a nice day! |
No description provided.