Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 ⚰️ Remove Redis and Webhooks Web from Tilt #1099

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

rblaine95
Copy link
Collaborator

@rblaine95 rblaine95 commented Oct 9, 2024

  • Remove Redis and Webhooks Web from Tilt
  • Make Endorser depend on NATS

@rblaine95 rblaine95 self-assigned this Oct 9, 2024
@rblaine95 rblaine95 force-pushed the chore/remove-redis-webhooks-tilt branch from de45aa8 to 5e22b99 Compare October 9, 2024 11:17
rblaine95 and others added 4 commits October 9, 2024 14:43
* Remove Webhooks and Redis Logs
* Skip Webhooks tests
* `bitnami/nats` `8.4.2` -> `8.4.4
* `bitnami/postgresql-ha` `14.2.28` -> `14.2.33`
* `runix/pgadmin4` `1.29.0` -> `1.31.0`
@rblaine95 rblaine95 force-pushed the chore/remove-redis-webhooks-tilt branch from 5f87475 to 83a2fbd Compare October 9, 2024 12:43
@rblaine95 rblaine95 marked this pull request as ready for review October 9, 2024 12:44
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

github-actions bot commented Oct 9, 2024

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py86298%153–154
app/routes
   issuer.py185299%682–683
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   trust_registry.py62297%52–53
   verifier.py1483378%100–102, 107, 167–169, 174, 250, 258–260, 265, 309–314, 320–322, 395–397, 403, 442–444, 449, 485–487, 543–545
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   jws.py422736%35–60, 76–99
   sd_jws.py422736%36–61, 78–101
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py1723580%118–160, 201–205, 372–376, 415–420, 453–457, 485–490, 539–540
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 205–206
   acapy_issuer_v2.py1011288%63, 97–106, 110, 126–127, 173, 227–228, 255
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_connections.py149299%281–282
   test_jsonld.py591673%134–169
   test_proof_request_models.py32197%132
   test_tenants.py4201596%203, 247–248, 287, 788, 832–833, 842–843, 852–853, 865–866, 875–876
   test_wallet_credentials.py30197%55
   test_wallet_dids.py701086%101–116
   test_webhooks.py391269%18–24, 33–39
app/tests/e2e/issuer
   test_get_records_paginated.py63297%66–67
   test_save_exchange_record.py74199%180
app/tests/e2e/verifier
   test_get_records_paginated.py62297%60–61
   test_many_revocations.py614034%31–108, 118–129, 140–216
   test_proof_revoked_credential.py451273%130–203
   test_verifier.py2371295%693–764
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1203769%176, 271–352, 365–437
   definitions.py662661%29–50, 64–65, 94–124, 143–144
   member_acapy_clients.py36489%47–50, 73–74
   member_connections.py43881%80–91, 130–141
   member_wallets.py611575%29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
   test_create_offer.py39197%150
   test_send_credential.py36197%129
app/tests/routes/wallet/dids
   test_get_public_did.py29197%40
app/tests/services
   test_revocation_registry.py149299%75, 106
app/tests/services/issuer
   test_issuer.py160299%359–363
app/tests/util
   connections.py872967%104–129, 138–155, 172–181, 236–256
   ledger.py501080%35, 43, 55, 63–67, 77, 83
   regression_testing.py351751%33, 41–68, 74–81
   sse_listener.py421662%39–55, 79–84
   trust_registry.py29390%24, 27–28
   webhooks.py56591%20, 79–82, 105, 129
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   assert_public_did.py18856%17–33
   credentials.py13285%11, 18
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%31–32
endorser
   main.py37197%55
endorser/services
   endorsement_processor.py94298%110–111
endorser/tests
   test_util_endorsement.py144597%286, 291, 350–352
endorser/util
   endorsement.py68790%134–146
trustregistry
   main.py45198%58
waypoint
   main.py48198%64
waypoint/tests/routers
   test_waypoint_sse.py83594%61–62, 119, 136, 171
waypoint/tests/services
   test_nats_service.py116397%45, 133, 155
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py22312444%105, 144–188, 198–231, 236–242, 255–280, 289–400, 460–470, 476–494
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2343685%155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/e2e
   test_sse.py987029%26–50, 61–84, 95–121, 132–156, 162–175, 180–185, 189–195, 203–206
   test_webhooks.py382632%16–38, 48–70
webhooks/tests/services
   test_acapy_events_processor.py1695369%122–151, 161–173, 181–188, 195–216, 223–230, 237–243, 249–278, 286–306
   test_sse_manager.py179398%214–215, 221
webhooks/web
   main.py14140%1–36
webhooks/web/routers
   sse.py102397%168–171
TOTAL15541126292% 

Tests Skipped Failures Errors Time
1109 21 💤 0 ❌ 0 🔥 4m 45s ⏱️

Copy link

github-actions bot commented Oct 9, 2024

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py86298%153–154
app/routes
   issuer.py185299%682–683
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   trust_registry.py62297%52–53
   verifier.py1483378%100–102, 107, 167–169, 174, 250, 258–260, 265, 309–314, 320–322, 395–397, 403, 442–444, 449, 485–487, 543–545
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   jws.py422736%35–60, 76–99
   sd_jws.py422736%36–61, 78–101
app/services
   acapy_ledger.py611969%43–49, 79, 110–111, 124–140, 146–149, 196–197
   acapy_wallet.py401270%49–64, 98–99
   revocation_registry.py1724673%118–160, 201–205, 372–376, 415–420, 453–457, 475–490, 496–505, 539–540
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 205–206
   acapy_issuer_v2.py1011288%63, 97–106, 110, 126–127, 173, 227–228, 255
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_connections.py149299%281–282
   test_definitions.py795135%33–56, 68–80, 92–106, 118–146, 164–209
   test_jsonld.py591673%134–169
   test_proof_request_models.py32197%132
   test_revocation.py1117334%27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349
   test_tenants.py42036314%29–73, 84–117, 128–172, 185–254, 265–316, 329–458, 467–519, 528–564, 573–622, 631–680, 691–733, 745–794, 805–876, 885–992
   test_wallet_dids.py701579%101–116, 128–139
   test_webhooks.py391269%18–24, 33–39
app/tests/e2e/issuer
   test_get_records_paginated.py635217%25–162
   test_save_exchange_record.py74199%180
app/tests/e2e/verifier
   test_get_credentials_by_proof_id.py251252%27–82
   test_get_records_paginated.py624921%27–156
   test_many_revocations.py614034%31–108, 118–129, 140–216
   test_proof_revoked_credential.py451176%39–116
   test_verifier_oob.py722368%140–247
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1205653%132–207, 216–224, 234–256, 290–350, 385–435
   definitions.py661085%41–48, 57–63, 114–121, 134–139
   member_acapy_clients.py36489%47–50, 73–74
   member_async_clients.py50296%32–33
   member_connections.py43491%73, 91, 123, 141
   member_wallets.py611575%23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
   test_create_offer.py39197%150
   test_send_credential.py36197%129
app/tests/routes/wallet/dids
   test_get_public_did.py29197%40
app/tests/services
   test_revocation_registry.py149299%75, 106
app/tests/services/issuer
   test_issuer.py160299%359–363
app/tests/util
   connections.py871978%154–155, 169, 181, 191–223, 251–256
   ledger.py502648%34–59, 63–67, 73–86
   regression_testing.py35974%33, 60–68, 74–81
   sse_listener.py421662%39–55, 79–84
   tenants.py241250%10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
   trust_registry.py29776%20–28
   webhooks.py56591%20, 79–82, 105, 129
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   assert_public_did.py181233%14–34
   check_endorser_connection.py10460%14–24
   credentials.py13285%11, 18
   retry_method.py363017%15–36, 68–114
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14750%18–36
endorser
   main.py37197%55
endorser/services
   endorsement_processor.py94298%110–111
endorser/tests
   test_util_endorsement.py144597%286, 291, 350–352
endorser/util
   endorsement.py68790%134–146
trustregistry
   main.py45198%58
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py22312444%105, 144–188, 198–231, 236–242, 255–280, 289–400, 460–470, 476–494
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2343685%155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/e2e
   test_sse.py987029%26–50, 61–84, 95–121, 132–156, 162–175, 180–185, 189–195, 203–206
   test_webhooks.py382632%16–38, 48–70
webhooks/tests/services
   test_acapy_events_processor.py1695369%122–151, 161–173, 181–188, 195–216, 223–230, 237–243, 249–278, 286–306
   test_sse_manager.py179398%214–215, 221
webhooks/web
   main.py14140%1–36
webhooks/web/routers
   sse.py102397%168–171
TOTAL15106192187% 

Tests Skipped Failures Errors Time
1109 58 💤 0 ❌ 0 🔥 6m 16s ⏱️

@rblaine95
Copy link
Collaborator Author

EKS tests are failing, most likely due to the Alembic PR and DB migrations.

This doesn't affect EKS at all, so I think this is safe to merge @ff137 @cl0ete

@rblaine95 rblaine95 merged commit b0e24aa into development Oct 9, 2024
54 of 56 checks passed
@rblaine95 rblaine95 deleted the chore/remove-redis-webhooks-tilt branch October 9, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants