-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Implement DID Exchange and DID Rotate methods and ποΈ deprecate connections protocol #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
changed the title
π§ Deprecate connections protocol and implement DID Exchange and DID Rotate methods
β¨ Implement DID Exchange and DID Rotate methods and ποΈ deprecate connections protocol
Oct 16, 2024
Quality Gate passedIssues Measures |
ff137
added a commit
that referenced
this pull request
Oct 17, 2024
β¦ections protocol (#1119) * ποΈ mark deprecated routes * π§ initial implementation of new did-exchange routes * π¨ modify default extra settings example * π§ Update default pylint config * π¨ update docstrings and available optional params * π§ e2e test under construction * β fix up create request tests * π fix protocol: /1.1 doesn't work ... * π use_public_did must be false in accept-request * β working tests for accept-request * π¨ remove unused endpoint and update route names * π¨ update route names * π¨ accept reject reason sa body instead of param * β¬οΈ Use latest cloudcontroller * β¬οΈ Update lock files * β¨ implement did-rotate endpoints * π§ add max-positional-arguments to pylintrc * β¬οΈ use latest cloudcontroller * β¬οΈ Update lock files * β¨ Use did-rotate/hangup in deletion of connection record (if using didexchange protocol) * β Fix deleting records when using oob connections * β assert connections are complete for both parties * β e2e tests for did-rotate * β¬οΈ Helmfile `0.169`, Helm `3.16.2`, Tailscale `1.76.0` (#1123) * π Pin `xk6` and plugin versions (#1124) * `xk6-sse` isn't compatible with `k6>=0.53` * Pin `xk6` and all plugins to the latest compatible versions * Also bump Golang to `1.23` * π Explicitly pin k6 to `v0.52.0` (#1125) * β¬οΈ Update lock files * π¨ * β 100% unit test coverage for new did-exchange and did-rotate methods * β fixed up delete connection test * π Reconfigure ACAPY_AUTO_ACCEPT_REQUESTS for Faber after test completes * β add cleaning up of connection records, for regression fixtures not to get bloated --------- Co-authored-by: Robbie Blaine <4052340+rblaine95@users.noreply.github.com>
ff137
added a commit
that referenced
this pull request
Oct 17, 2024
* add max attempts env * π¨ * must be int * reset to 15 * add temp debug log * more temp debug logs * dont reset nats * revert reset nats * remove temp debug logging * add heartbeat to fetch * import fetch time out error * on fetch timeout continue * on generic timeout re-subscribe * update imports * fix test * add tests for health endpoints * update health endpoints * add check jetstream func for health checks * fix test * π¨ * update endorser health endpoint * β¨ Implement DID Exchange and DID Rotate methods and ποΈ deprecate connections protocol (#1119) * ποΈ mark deprecated routes * π§ initial implementation of new did-exchange routes * π¨ modify default extra settings example * π§ Update default pylint config * π¨ update docstrings and available optional params * π§ e2e test under construction * β fix up create request tests * π fix protocol: /1.1 doesn't work ... * π use_public_did must be false in accept-request * β working tests for accept-request * π¨ remove unused endpoint and update route names * π¨ update route names * π¨ accept reject reason sa body instead of param * β¬οΈ Use latest cloudcontroller * β¬οΈ Update lock files * β¨ implement did-rotate endpoints * π§ add max-positional-arguments to pylintrc * β¬οΈ use latest cloudcontroller * β¬οΈ Update lock files * β¨ Use did-rotate/hangup in deletion of connection record (if using didexchange protocol) * β Fix deleting records when using oob connections * β assert connections are complete for both parties * β e2e tests for did-rotate * β¬οΈ Helmfile `0.169`, Helm `3.16.2`, Tailscale `1.76.0` (#1123) * π Pin `xk6` and plugin versions (#1124) * `xk6-sse` isn't compatible with `k6>=0.53` * Pin `xk6` and all plugins to the latest compatible versions * Also bump Golang to `1.23` * π Explicitly pin k6 to `v0.52.0` (#1125) * β¬οΈ Update lock files * π¨ * β 100% unit test coverage for new did-exchange and did-rotate methods * β fixed up delete connection test * π Reconfigure ACAPY_AUTO_ACCEPT_REQUESTS for Faber after test completes * β add cleaning up of connection records, for regression fixtures not to get bloated --------- Co-authored-by: Robbie Blaine <4052340+rblaine95@users.noreply.github.com> * π© add sleep to avoid mysterious 500 error --------- Co-authored-by: Mourits de Beer <31511766+ff137@users.noreply.github.com> Co-authored-by: Robbie Blaine <4052340+rblaine95@users.noreply.github.com> Co-authored-by: ff137 <ff137@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β¨ Implements DID-Exchange and DID-Rotate methods in our Connections API
New endpoints under /connections:
ποΈ Deprecates the following endpoints:
β Includes e2e and unit test coverage
π Upgraded cloudcontroller now allows Create Local DID support for: did:web, did:peer2, did:peer:4
Closes #910