Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken, infinitely looping minPresenceAhead calculation #2400

Merged
merged 7 commits into from
Jan 15, 2024
Merged

fix: broken, infinitely looping minPresenceAhead calculation #2400

merged 7 commits into from
Jan 15, 2024

Commits on Sep 21, 2023

  1. Rework breaking logic and add tests to fix minPresenceAhead 

    The old minPresenceAhead had some major issues, among others because
vertical margins were completely ignored in the presence calculations.
    @carlobeltrame
    carlobeltrame committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    efabfe4 View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @carlobeltrame
    carlobeltrame committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    07e717a View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Add regression tests

    @carlobeltrame
    carlobeltrame committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ce8c567 View commit details
    Browse the repository at this point in the history

  2. Ignore fixed elements when calculating page breaks

    @carlobeltrame
    carlobeltrame committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4db0805 View commit details
    Browse the repository at this point in the history

  3. Do not break before a wrapping element

    @carlobeltrame
    carlobeltrame committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f8d281f View commit details
    Browse the repository at this point in the history

  4. Rename variable to make it easier to understand

    @carlobeltrame
    carlobeltrame committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4bddd93 View commit details
    Browse the repository at this point in the history

  5. Refactor for better readability

    @carlobeltrame
    carlobeltrame committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ff69234 View commit details
    Browse the repository at this point in the history