Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uuid to 0.8.x #2205

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Bump uuid to 0.8.x #2205

merged 2 commits into from
Oct 22, 2019

Conversation

weiznich
Copy link
Member

Fixes #2204

@weiznich weiznich requested a review from a team October 21, 2019 20:24
@@ -14,12 +14,12 @@ dotenv = ">=0.8, <0.11"
[dependencies]
assert_matches = "1.0.1"
chrono = { version = "0.4" }
diesel = { path = "../diesel", default-features = false, features = ["quickcheck", "chrono", "uuid", "serde_json", "network-address", "numeric", "with-deprecated"] }
diesel = { path = "../diesel", default-features = false, features = ["quickcheck", "chrono", "uuidv07", "serde_json", "network-address", "numeric", "with-deprecated"] }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more realistic to use the new uuid versions in the test.

@weiznich weiznich merged commit 54c435c into diesel-rs:master Oct 22, 2019
@ForsakenHarmony
Copy link

when will this be released?

@weiznich
Copy link
Member Author

With the next release. We do not give any ETA‘s other that: When it's done.
(Asking those questions will not make that happen any sooner.)

@ForsakenHarmony
Copy link

ForsakenHarmony commented Feb 1, 2020

Do you have any milestones or smth one could look at to see what's required for it to be done?

@weiznich
Copy link
Member Author

weiznich commented Feb 1, 2020

Alt least everything in https://github.com/diesel-rs/diesel/milestone/16. Additionally anything that seems useful and is ready till the completion of the mile stone.
Otherwise if someone really needs a release containing the version bumps, they should backport the required changes (and everything else marked as "maybe backport") to the 1.4.x branch and open a PR. If everything is fine I may find some time to do a release, but I cannot promise anything concrete there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uuid v0.8 support
3 participants