Migrate the main crate to the 2018 edition. #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this does not make any idiom adjustments, nor does it make the crate usable without `#[macro_use] extern crate diesel;`. This is the result of running `cargo fix --edition`, fixing the broken code it generated, and then manually fixing the doctests. As part of this I noticed a few doctests that expected the `extras` feature to be able to run. I fixed those, and also realized that the `Macaddr` type's impls are hidden behind the `network-address` feature for no real reason.
JohnTitor
approved these changes
Dec 18, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not make any idiom adjustments, nor does it make the
crate usable without
#[macro_use] extern crate diesel;. This is theresult of running
cargo fix --edition, fixing the broken code itgenerated, and then manually fixing the doctests.
As part of this I noticed a few doctests that expected the
extrasfeature to be able to run. I fixed those, and also realized that the
Macaddrtype's impls are hidden behind thenetwork-addressfeaturefor no real reason.