-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipnet-address
feature, providing conversions to/from the ipnet
crate
#3165
Conversation
ipnet-address
feature, providing conversions to/from the ipnet
crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me if a changelog entry is added.
To note this somewhere: This likely won't be part of the initial 2.0 release, as it's not part of the RC release.
@smklein Just a remainder that this is only waiting for the Changelog entry to be added. |
This is done; added it under "Unreleased", as you mentioned this would not be part of the 2.0 release. |
The clippy CI failure seems to be relevant. |
Okay, I believe this has been fixed - mysql failures still look present, but those also look present on the master branch |
Those are caused by an incompatibility between the visual studio version available on github actions and the installed libmysqlclient version. I'm not sure yet how to fix that. |
NOTE: this is one possible prototype of #3164
Details:
ipnet-address
feature, which acts exactly likenetwork-address
, but using theipnet
crate instead ofipnetwork
.network-address
, but allows the features to remain functional simultaneously.