Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test reproducing #3646 #3650

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

tp-woven
Copy link
Contributor

@tp-woven tp-woven commented Jun 6, 2023

This test reproduces #3646: Adding two foreign keys referencing the same table that have the same name "confuses" load_foreign_key_constraints.

@tp-woven tp-woven changed the title dd test reproducing #3646 add test reproducing #3646 Jun 6, 2023
@weiznich
Copy link
Member

weiznich commented Jun 7, 2023

Thanks for providing this test. That was really helpful. I've pushed 0a252c3 to fix that issue. Can you confirm that it also fixes your usecase?

@weiznich weiznich requested a review from a team June 7, 2023 12:34
@weiznich weiznich marked this pull request as ready for review June 7, 2023 12:34
@tp-woven
Copy link
Contributor Author

tp-woven commented Jun 8, 2023

Thanks for the quick fix! 🙏
Confirmed that after checking-out this branch and installing diesel_cli from it, the issue is solved.

@weiznich weiznich enabled auto-merge June 8, 2023 06:16
@weiznich weiznich added this pull request to the merge queue Jun 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 8, 2023
@weiznich weiznich added this pull request to the merge queue Jun 8, 2023
Merged via the queue into diesel-rs:master with commit a4e6131 Jun 8, 2023
weiznich added a commit to weiznich/diesel that referenced this pull request Aug 18, 2023
@weiznich weiznich mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants