Enable distinct_on with postgres_backend instead of postgres
#3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ten0
approved these changes
Jun 20, 2023
JohnTitor
approved these changes
Jun 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Aug 18, 2023
Enable `distinct_on` with `postgres_backend` instead of `postgres`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when working with
QueryDslthat the methoddistinct_onis only available when Diesel is compiled with thepostgresfeature.The trait this function is based on though is available when compiling the crate with
postgres_backend.This PR changes the cfg flag above the function declaration to
postgres_backend.The change shouldn't be breaking since the
postgresfeature enables thepostgres_backendfeature.