-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the array concat operation in the dsl #3660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation-wise this looks correct
I'm confident for merge if this is tested (either manually or by adding an auto-test) (once all the comments are solved of course)
069f2bd
to
732497c
Compare
I think this should fix the documentation |
Can you please repush to trigger the CI? |
One compiletest somehow fails, but i am not familiar enough with detailed typesystem to figure out why it does. Maybe you guys could take a look, if you can spot the bug. I could imagine that it has something to do with the nested type of |
The error might be caused by an actually changed error message. Sometimes the error messages contains a number how many types implement a certain trait and that number changes if we add another impl (as that happens here). You can just run the compile tests with |
This actually seemed to be the problem. Thank you very much! |
This adds support for the
||
operator on arrays. This feature was already requested in #1412