Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the array concat operation in the dsl #3660

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

sintemal
Copy link
Contributor

This adds support for the || operator on arrays. This feature was already requested in #1412

@weiznich weiznich requested a review from a team June 20, 2023 10:14
Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation-wise this looks correct

I'm confident for merge if this is tested (either manually or by adding an auto-test) (once all the comments are solved of course)

diesel/src/pg/expression/helper_types.rs Outdated Show resolved Hide resolved
@sintemal sintemal closed this Jun 22, 2023
@sintemal sintemal force-pushed the master branch 2 times, most recently from 069f2bd to 732497c Compare June 22, 2023 12:22
@sintemal sintemal reopened this Jun 22, 2023
@sintemal
Copy link
Contributor Author

I think this should fix the documentation

@pksunkara pksunkara enabled auto-merge June 22, 2023 15:13
@pksunkara pksunkara disabled auto-merge June 22, 2023 15:13
@pksunkara
Copy link
Member

Can you please repush to trigger the CI?

@sintemal
Copy link
Contributor Author

One compiletest somehow fails, but i am not familiar enough with detailed typesystem to figure out why it does. Maybe you guys could take a look, if you can spot the bug. I could imagine that it has something to do with the nested type of Array<ST> and that __diesel_internal_SameResultAsInputin operators.rs doesn't support this...

@weiznich
Copy link
Member

The error might be caused by an actually changed error message. Sometimes the error messages contains a number how many types implement a certain trait and that number changes if we add another impl (as that happens here). You can just run the compile tests with TRYBUILD=overwrite set to regenerate the changed files. Use the git diff to see what exactly changed and commit the changes if its something trivial as mentioned above.

@sintemal
Copy link
Contributor Author

This actually seemed to be the problem. Thank you very much!

@weiznich weiznich added this pull request to the merge queue Jun 29, 2023
Merged via the queue into diesel-rs:master with commit d8cade5 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants