Fix #3748 #3752
Merged
Fix #3748 #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
approved these changes
Aug 16, 2023
|
Nice, i just tried this and it works great! Thanks for the quick fix. |
BlackDex
approved these changes
Aug 16, 2023
We now also generate the necessary `FromSql`/`ToSql` impls for `chrono`/`time` types for `Time`/`Date`/`Timestamp`. This follows the same reasoning as #diesel-rs#3747.
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Aug 18, 2023
This was referenced Aug 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now also generate the necessary
FromSql/ToSqlimpls forchrono/timetypes forTime/Date/Timestamp. This follows the same reasoning as ##3747.