Fix typo #3932
Closed
Fix typo #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
approved these changes
Feb 10, 2024
|
I ran into this issue too. I think the fix is a little more complicated. Since this typo had been preventing the CI job from running these tests, they have drifted a bit. This would normally be visible but the sqlite ASAN changes are preventing the full CI job from running. You can cherry-pick commit dvogel@46349b9 to get the fixes for the tests. You can see a CI run for those changes here (though that branch has some additional commits you won't want to allow the test job to be run). |
|
This still needs to wait for rust-lang/rust#120830 to being fixed. Otherwise this should work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.