add some multirange operations support #4261
Conversation
guissalustiano
force-pushed
the
multirange_contains
branch
from
0fda44e
to
8430246
Compare
guissalustiano
changed the title
| @@ -1779,7 +1790,7 @@ pub trait PgRangeExpressionMethods: Expression + Sized { | |||
| impl<T> PgRangeExpressionMethods for T | |||
| where | |||
| T: Expression, | |||
| T::SqlType: RangeOrNullableRange, | |||
| T::SqlType: MultirangeOrRangeMaybeNullable, | |||
There was a problem hiding this comment.
I can't test without flipping this, and this allows all the range operations to accept multirange without proper test. What do the reviewers think? Can I merge the PR like that and add tests in the future in other small PRs, or should I add a multirange test for all the range methods?
There was a problem hiding this comment.
The correct way to handle this would be to split up this trait into two:
- The
PgRangeExpressionMethodscontains methods that are only available forRangebut not forMultiRange. That is then only implemented forT::SqlType: RangeOrNullableRange - The
PgRangeAndMultirangeMethodscontains methods that are available for both
(If there are methods that are only available for MultiRange we would just add a third trait for that.)
I would prefer having at least one test for range + one for multirange for each of the supported methods.
There was a problem hiding this comment.
I did a fast check, and it looks like all the range operations are also multirange operations. If this is the case, do you still want to rename it to PgRangeAndMultirangeMethods?
I will add the tests for each of the supported methods in this PR
There was a problem hiding this comment.
In this case it should be fine to keep the old name.
Add multirange contains support under #4240
It is a small test to check the format before moving everything else