Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve range_merge type signature with new CombinedNullableValue #4262

Merged
merged 1 commit into from
Sep 15, 2024
Merged

improve range_merge type signature with new CombinedNullableValue #4262

merged 1 commit into from
Sep 15, 2024

Conversation

guissalustiano
Copy link
Contributor

@guissalustiano guissalustiano commented Sep 13, 2024 •
edited
Loading

This PR uses CombinedNullableValue introduced in b488df4 on range_merge

Looking at the other signatures, I couldn't find any other place where we can use this new type.

@guissalustiano guissalustiano requested a review from a team September 13, 2024 17:20
weiznich
weiznich approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@weiznich weiznich added this pull request to the merge queue Sep 15, 2024
Merged via the queue into diesel-rs:master with commit 055939f Sep 15, 2024
48 checks passed
@guissalustiano guissalustiano deleted the feat_improve_range_merge_type branch September 15, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guissalustiano @weiznich