Set default busy timeout to 5 seconds #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to: jgallagher/rusqlite@05b03ae this should reduce SQLITE_BUSY situation
|
Thanks. Can you provide a bit more information what this "SQLITE_BUSY situation" is and how this solves it? :)
… Am 02.06.2017 um 11:08 schrieb wangcong ***@***.***>:
similar to:
***@***.***
this should reduce SQLITE_BUSY situation
You can view, comment on, or merge this pull request online at:
#929
Commit Summary
• Set default busy timeout to 5 seconds
File Changes
• M diesel/Cargo.toml (1)
• M diesel/src/lib.rs (2)
• M diesel/src/sqlite/connection/raw.rs (16)
Patch Links:
• https://github.com/diesel-rs/diesel/pull/929.patch
• https://github.com/diesel-rs/diesel/pull/929.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
yeah, this deals with multiple concurrent sqlite writers. there are some discussions like here:and also these documentations:tldr:
reference: https://github.com/jgallagher/rusqlite/blob/master/src/row.rs#L43 |
|
I'd rather not introduce the log crate or warnings for this. We need to properly return an error here. |
this commit only logs the error, but can more refine grained method should be used. reference: https://github.com/jgallagher/rusqlite/blob/master/src/row.rs#L43
|
Updated :) |
|
@sgrif @killercup These changes turn out working well in our project, any ideas? |
We cannot accept a PR that simply has |
|
Going to close this, as it's been sitting around for a while. Feel free to re-submit if you're still interested in working on this. However for this to be accepted we'd need to present this error case to the user. Silently treating it as an empty result set is not an acceptable solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to:
jgallagher/rusqlite@05b03ae
this should reduce SQLITE_BUSY situation