Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Browse view #25

Closed
11 tasks done
eboileau opened this issue Jun 20, 2023 · 2 comments
Closed
11 tasks done

Implement Browse view #25

eboileau opened this issue Jun 20, 2023 · 2 comments
Assignees
Labels
stack:frontend Frontend (FE) related

Comments

@eboileau
Copy link
Collaborator

eboileau commented Jun 20, 2023

Aims/objectives.

A base Browse view is implemented. This issue tracks more todos, questions, etc. as we're integrating server-side into the app.

A clear and concise description of todo items.

Browse View tasks


Functionality

  • Link DOI, PMID where available. What to show in Dialog?
  • Status (public, restricted). We first need to implement authentication and authorization into a secure API.
  • Test export (w/ filters).

Bug/Questions

  • InputText (icons can be placed inside an input element by wrapping both the input and the icon with an element that has either .p-input-icon-left or .p-input-icon-right class) icon not working, probably due to unstyle mode? Check this old issue. Check also this.
  • Add a selection (add to basket) functionality for logged-in users, allowing to save dataset for reference and future use. We first need to implement authentication and authorization into a secure API.

Styling

  • Row Group by SMID.
  • Dialog overflows for title and/or summary. Check Long Content, Maximizable, and/or Responsive, or use instead a dialog specific to e.g. SMID and EUFID, or and OverlayPanel. Add missing doi/pmid. Published remove time (also from added?)
  • How to display dataset-specific additional information such as that included in the bedRMod header (see point above)?
  • Divider color (redefine).
  • Harmonize buttons (hover, border, etc.) - across views.
  • Sizing rows or columns, accessibility.
@eboileau eboileau self-assigned this Jun 20, 2023
@eboileau eboileau added the stack:frontend Frontend (FE) related label Jun 20, 2023
@eboileau eboileau mentioned this issue Sep 28, 2023
1 task
@eboileau eboileau added the status:in-progress This issue is being dealt with label Nov 2, 2023
eboileau added a commit that referenced this issue Nov 2, 2023
@eboileau eboileau changed the title Implemenet Browse view Implement Browse view Nov 2, 2023
@eboileau
Copy link
Collaborator Author

eboileau commented Jan 8, 2024

I don't think grouping by SMID would make the app more appealing or easier to use, we can just filter the table to recover dataset from a given project. In all cases, this can be implemented later.

The Dialog looks fine now, we can customize later on demand, e.g. adding bedRMod header, etc. but see #63.

@eboileau eboileau removed the status:in-progress This issue is being dealt with label Jan 8, 2024
@eboileau
Copy link
Collaborator Author

eboileau commented Jan 8, 2024

Remaining todos moved to their own respective issues.

@eboileau eboileau closed this as completed Jan 8, 2024
eboileau added a commit that referenced this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stack:frontend Frontend (FE) related
Projects
None yet
Development

No branches or pull requests

1 participant