Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run performance comparison in CI using Kani's Benchcomp #8171

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

tautschnig
Copy link
Collaborator

Use proof harnesses in AWS C Common as (initial) benchmark to guard against performance regressions introduced in PRs. See the "Summary" behind any of the executions of
https://github.com/model-checking/kani/actions/workflows/bench.yml for examples what the output will look like.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (baaccb6) to head (ddb4060).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8171   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1684           
  Lines       195661   195661           
========================================
  Hits        155837   155837           
  Misses       39824    39824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the features/benchcomp branch 5 times, most recently from 5467902 to a7d0189 Compare January 29, 2024 15:20
@tautschnig tautschnig force-pushed the features/benchcomp branch 6 times, most recently from 3ac5219 to 14f1334 Compare February 6, 2024 12:38
@tautschnig tautschnig marked this pull request as ready for review February 6, 2024 13:20
@tautschnig tautschnig requested review from peterschrammel and a team as code owners February 6, 2024 13:20
Copy link
Collaborator

@karkhaz karkhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finally gotten round to this, sorry for the delay. Thank you so much for adding this!

.github/workflows/performance.yaml Outdated Show resolved Hide resolved
.github/workflows/performance.yaml Outdated Show resolved Hide resolved
@tautschnig
Copy link
Collaborator Author

Will wait for model-checking/kani#3077 to be merged: with that one we'll also get scatterplots (see that PR for examples).

Use proof harnesses in AWS C Common as (initial) benchmark to guard
against performance regressions introduced in PRs. See the "Summary"
behind any of the executions of
https://github.com/model-checking/kani/actions/workflows/bench.yml for
examples what the output will look like.

Co-authored-by: Kareem Khazem <karkhaz@amazon.com>
@tautschnig
Copy link
Collaborator Author

https://github.com/diffblue/cbmc/actions/runs/8356289780 now includes examples of scatterplots.

@tautschnig tautschnig merged commit 9cbfe7e into diffblue:develop Mar 20, 2024
40 checks passed
@tautschnig tautschnig deleted the features/benchcomp branch March 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants