Fix: Ensure Mode.interactive is default in CI environment

Co-Authored-By: ned.twigg@diffplug.com <ned.twigg@diffplug.com>

.github/workflows/python-ci.yml

@@ -59,6 +59,7 @@ jobs:
           else
             . ../../.venv/bin/activate
           fi
+          unset SELFIE || true
           python -m pytest -vv
 
       - name: selfie-lib - pyright
@@ -104,6 +105,7 @@ jobs:
           else
             . ../../.venv/bin/activate
           fi
+          unset SELFIE || true
           python -m pytest -vv
 
       - name: pytest-selfie - pyright
@@ -149,6 +151,7 @@ jobs:
           else
             . ../../.venv/bin/activate
           fi
+          unset SELFIE || true
           python -m pytest -vv
 
       - name: example-pytest-selfie - pyright

python/pytest-selfie/pytest_selfie/SelfieSettingsAPI.py

@@ -28,19 +28,19 @@ def root_folder(self) -> Path:
         return self.root_dir
 
     def calc_mode(self) -> Mode:
-        override = os.getenv("selfie") or os.getenv("SELFIE")  # noqa: SIM112
-        if override:
-            # Convert the mode to lowercase and match it with the Mode enum
+        selfie_env = os.getenv("selfie") or os.getenv("SELFIE")  # noqa: SIM112
+        if selfie_env:
+            # Only use env var if explicitly set to "readonly"
+            if selfie_env.lower() == "readonly":
+                return Mode.readonly
             try:
-                return Mode[override.lower()]
+                # For backward compatibility, try to match other mode names
+                return Mode[selfie_env.lower()]
             except KeyError:
-                raise ValueError(f"No such mode: {override}") from None
+                raise ValueError(f"No such mode: {selfie_env}") from None
 
-        ci = os.getenv("ci") or os.getenv("CI")  # noqa: SIM112
-        if ci and ci.lower() == "true":
-            return Mode.readonly
-        else:
-            return Mode.interactive
+        # Default to interactive mode when no environment variables are set
+        return Mode.interactive
 
 
 class SelfieSettingsSmuggleError(SelfieSettingsAPI):