Fix subgroups leading catch all matcher #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Jan 13, 2023
| @@ -41,6 +41,12 @@ void sortImportsFromArrayWithSubgroups() { | |||
| StepHarness.forStep(step).testResource("java/importsorter/JavaCodeUnsortedImportsSubgroups.test", "java/importsorter/JavaCodeSortedImportsSubgroups.test"); | |||
| } | |||
|
|
|||
| @Test | |||
| void sortImportsFromArrayWithSubgroupsLeadingCatchAll() { | |||
| FormatterStep step = ImportOrderStep.forJava().createFrom("\\#|"); | |||
There was a problem hiding this comment.
Verified that it fails without this change.
|
Thanks for the fix! I'm trying to release today, but migrating our deployment from CircleCI to GitHub has been surprisingly tricky... |
|
Published in |
|
@nedtwigg Thank you! I'm trying this version now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to #1401.