Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bytecode to 11 #1530

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Bump bytecode to 11 #1530

merged 8 commits into from
Jan 26, 2023

Conversation

nedtwigg
Copy link
Member

We can start using Java 11 API and deps now that we've published a release (plugin-gradle 6.14.0 and plugin-maven 2.31.0) which can run on Java 8 just enough to yell at the user about updating.

@simschla
Copy link
Contributor

@nedtwigg I think it might be necessary to update these lines too:

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

Or are they irrelevant?

@nedtwigg
Copy link
Member Author

Thanks for reviewing this!

Those lines mean that mvn compile will produce a jar that can run on JRE 8, even if the JDK doing the build is anything 8+.

https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump minimum required JRE to 11?
2 participants