Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit contextual error message during incremental m2e builds #1962

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Dec 8, 2023

This closes #1960

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@kwin kwin marked this pull request as draft December 8, 2023 17:13
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start :)

Keep CleanProviderFormatter private
Use Map.entry() instead of AbstractMap.SimpleEntry()
@kwin kwin marked this pull request as ready for review December 9, 2023 18:41
@nedtwigg
Copy link
Member

Great! This just needs changelog entries in CHANGES.md and plugin-maven/CHANGES.md and then it's ready to merge.

@nedtwigg nedtwigg merged commit 6579264 into diffplug:main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M2E Support: Emit file specific errors during incremental build
2 participants