Add shell script support via shfmt #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add maven support as well? |
|
Thanks for the great PR! Maven support is very welcome, but you're under no obligation to fill the matrix. |
|
Published in |
|
Love this feature, thanks @tcrawford-figure ❤️ Wouldn't we need to add these special tests ( |
|
@simschla happy to hear that! Based on feedback from @nedtwigg in the maven PR #1998 (comment), yes. Adding these special tests to the github workflow would probably be good. I haven't had time to look into doing that yet. If you have time to work on that, by all means, please add support! Otherwise, I may look into it sometime in the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Gradle support for shfmt and addresses #1567