Remove the rome formatter #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I added support for biome after their transition from rome to biome, I changed at least the public API (i.e. the configuration in the pom.xml / gradle config). I left the Java classes unchanged to avoid any compatibility issues. But I suppose nobody actually includes this project as a dependency and builds against it, so it's probably ok to change it. Also, at least until now, we did support the old rome tool (justifying why some classes should be named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Rome had a political rename to Biome. We had a ton of code all over the place pointing this out. Looks like there's more refactoring that could be done, but this seems like the essential stuff.
@blutorange anything else you'd like to add?