Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied common Spotless Eclipse framework to JDT #239

Merged
merged 6 commits into from
Jul 18, 2018
Merged

Applied common Spotless Eclipse framework to JDT #239

merged 6 commits into from
Jul 18, 2018

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Apr 28, 2018

Applied common Spotless Eclipse framework to JDT (see #234).
Updated version and artifact ID as discussed in #226.

@fvgh
Copy link
Member Author

fvgh commented Apr 28, 2018

The new version will solve #191, as proven in internalCodeFormatter test.

@nedtwigg
Copy link
Member

Amazing!! Looks great

@nedtwigg nedtwigg mentioned this pull request Apr 28, 2018
Closed
@fvgh fvgh mentioned this pull request Apr 29, 2018
Merged
@fvgh
Copy link
Member Author

fvgh commented Apr 29, 2018

@nedtwigg Can you have a look at the README.md and maybe improve the wording? THX.

@nedtwigg
Copy link
Member

README looks good to me 👍

@fvgh
Aligned formatter step class name (including now the Eclipse formatte…
31dbf89 
…r bundles name JDT).

Refactored Spotless Eclipse frameworks setup to support latest snapshot version and benefit
form the JDT headless setup.
@fvgh fvgh mentioned this pull request Jun 30, 2018
Merged
@fvgh
Copy link
Member Author

fvgh commented Jul 15, 2018

@nedtwigg One remaining issue regarding this PR:
As you ca see in 8ce3295, Eclipse JDT 4.7.X has a slightly different formatting than 4.8.X. I cross checked with a local Eclipse Oxygen/Neon installation. The behaviour is reproducible.
So I think this PR is fine, but should we mention it somewhere? Or is it OK just to state that per default 4.8.0 is used with a new version of Spotless in the change log (not for this PR, but on branch eclipse_4_8_0_jdt?

@nedtwigg
Copy link
Member

My experience is that each new eclipse formatter has had little niggles similar to this. I think it's fine to just say in the changelog "Default eclipse has bumped to 4.8.0"

@fvgh fvgh merged commit 7cdfcb4 into master Jul 18, 2018
@nedtwigg
Copy link
Member

🎉

@fvgh
Copy link
Member Author

fvgh commented Jul 18, 2018

Sorry for the delay. Had some final issues with Eclipse-Groovy and just wanted to be entirely sure that it is something to be solved within Eclipse-Groovy impl. Framework and JDT are 100% ready for usage. Will provide Eclipse-Groovy tomorrow. Feel free to publish...

@nedtwigg
Copy link
Member

No problem, I'm turning the gears to publish com.diffplug.spotless:spotless-eclipse-base:3.0.0. If I should stop let me know, else it will be on mavencentral shortly :)

@fvgh
Copy link
Member Author

fvgh commented Jul 18, 2018

@nedtwigg I am afraid #261 is required.

@fvgh fvgh deleted the ext_eclipse_jdt branch July 19, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvgh @nedtwigg