Upgrade Ktlint maven coordinate (com.pinterest), default version (0.32.0)

[sharedprophet]

Update ktlint coords.

[nedtwigg]

Is com.pinterest:ktlint the new official ktlint? What version is the first pinterest version? We care about backwards compatibility, so we should do a comparison, if version > blah then group ="com.pinterest" else group = "com.github.shyiko".

[JLLeitschuh]

Here's how we resolved it for Ktlint-Gradle.

JLLeitschuh/ktlint-gradle#228

Since Ktlint implements SemVer for all versioning, we imported a library that supports SemVer comparisons to handle all this logic.

https://github.com/swiftzer/semver

@nedtwigg I don't know if you have an existing methodology for doing SemVer comparisons. Don't know what your thoughts are on adding a library to handle this sort of thing.

[sharedprophet]

0.31.0 is the last of com.github.shyiko, 0.32.0 is the first for com.pinterest

https://mvnrepository.com/artifact/com.github.shyiko/ktlint
https://mvnrepository.com/artifact/com.pinterest/ktlint

[nedtwigg]

what your thoughts are on adding a library to handle this sort of thing.

I'm against adding a dependency. Elsewhere in the code where we've had to change behavior based on a version, we've done feature-testing rather than version-testing, but that won't work here.

Every shyiko version has form 0.x.x, So if you did a regex like 0\.([0-9]+)\.([0-9]+) and then compared the digit to 31, that would work.

[nedtwigg]

Thanks @sharedprophet! This looks great, I've got a minor nit on the implementation.

Only thing we need to merge is a test - need to make sure it works for 0.32.0 and 0.31.0. Here's the existing test:

spotless/testlib/src/test/java/com/diffplug/spotless/kotlin/KtLintStepTest.java

Lines 27 to 39 in fd75332

	@Test
	public void behavior() throws Exception {
	// Must use jcenter because `com.andreapivetta.kolor:kolor:0.0.2` isn't available on mavenCentral.
	// It is a dependency of ktlint.
	FormatterStep step = KtLintStep.create(TestProvisioner.jcenter());
	StepHarness.forStep(step)
	.testResource("kotlin/ktlint/basic.dirty", "kotlin/ktlint/basic.clean")
	.testException("kotlin/ktlint/unsolvable.dirty", assertion -> {
	assertion.isInstanceOf(AssertionError.class);
	assertion.hasMessage("Error on line: 1, column: 1\n" +
	"Wildcard import");
	});
	}

Maybe have a worksShyiko test and a worksPinterest test?

[nedtwigg]

Also, we need to update plugin-maven/CHANGES.md and plugin-gradle/CHANGES.md. The same line that you used in CHANGES.md is fine.

[sharedprophet]

Also, we need to update plugin-maven/CHANGES.md and plugin-gradle/CHANGES.md. The same line that you used in CHANGES.md is fine.

I did update those... working on putting a test in the core tests now.

[nedtwigg]

LGTM, thanks! I'll let this breathe for 24 hrs then merge and release tomorrow.

[JLLeitschuh]

LGTM! Looking forward to this.

[nedtwigg]

Published in 3.23.0 / 1.23.0.