Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default KtLint to 0.35.0 #473

Merged
merged 1 commit into from
Nov 7, 2019
Merged

update default KtLint to 0.35.0 #473

merged 1 commit into from
Nov 7, 2019

Conversation

agebhar1
Copy link
Contributor

No description provided.

@nedtwigg
Copy link
Member

Unable to resolve dependencies: Failure to find com.pinterest:ktlint:jar:0.35.0 in https://maven-central.storage-download.googleapis.com/repos/central/data/

Thanks for PR, lemme know when ktlint 0.35.0 is live on mavencentral and I'll merge :)

@agebhar1
Copy link
Contributor Author

strange behaviour @nedtwigg - it's available on Maven Central but missing also here https://mvnrepository.com/artifact/com.pinterest.ktlint/ktlint-core ...

@nedtwigg
Copy link
Member

I just kicked-off a fresh build, and it failed again. You can replicate on your box with ./gradlew check.

Maven had a rough couple days at the end of last week: https://status.maven.org/

Screen Shot 2019-10-14 at 9 38 34 AM

Maybe 0.35.0 is stuck in limbo. People can use it in their builds now by setting the version manually, but I won't change the default until CI passes.

@agebhar1
Copy link
Contributor Author

agebhar1 commented Oct 14, 2019

Really strange. On my box I (Maven) can fetch the artifact from Googles Maven Central Mirror:

mvn dependency:get -Dartifact=com.pinterest:ktlint:0.35.0
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:get (default-cli) @ standalone-pom ---
[INFO] Resolving com.pinterest:ktlint:jar:0.35.0 with transitive dependencies
Downloading from google-maven-central: https://maven-central.storage-download.googleapis.com/repos/central/data/com/pinterest/ktlint/0.35.0/ktlint-0.35.0.pom
Downloaded from google-maven-central: https://maven-central.storage-download.googleapis.com/repos/central/data/com/pinterest/ktlint/0.35.0/ktlint-0.35.0.pom (15 kB at 7.1 kB/s)
Downloading from google-maven-central: https://maven-central.storage-download.googleapis.com/repos/central/data/com/pinterest/ktlint/0.35.0/ktlint-0.35.0.jar
Downloaded from google-maven-central: https://maven-central.storage-download.googleapis.com/repos/central/data/com/pinterest/ktlint/0.35.0/ktlint-0.35.0.jar (108 kB at 67 kB/s)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.328 s
[INFO] Finished at: 2019-10-14T19:37:01+02:00
[INFO] ------------------------------------------------------------------------

@nedtwigg nedtwigg merged commit 3a2620b into diffplug:master Nov 7, 2019
@nedtwigg
Copy link
Member

nedtwigg commented Nov 7, 2019

Reran the build, looks like the 0.35.0 finally propagated out

@agebhar1 agebhar1 deleted the feature/ktlint-0.35.0 branch November 7, 2019 20:21
@agebhar1
Copy link
Contributor Author

agebhar1 commented Nov 7, 2019

Nice, thanks!

@nedtwigg
Copy link
Member

Released in x.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants