Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ktfmt): add ktfmt a new Kotlin formatter from Facebook Incubator #569

Merged
merged 4 commits into from
May 5, 2020
Merged

feat(ktfmt): add ktfmt a new Kotlin formatter from Facebook Incubator #569

merged 4 commits into from
May 5, 2020

Conversation

distributedlock
Copy link
Contributor

@distributedlock distributedlock commented May 4, 2020

Adds a new Kotlin formatter ktfmt from Facebook Incubator. ktfmt underlying implementation utilizes google-java-format 1.8. As a result, this formatter has been enabled for JDK11 and above. Due to utilizing GJF, the formatter is meant to be opinionated like GJF so it doesn't have any configurable formatting options.

Please feel free to advise on any suggestions.

I'll squash the commits into one single commit once CI passes.

Related GJF 1.8 PR #563.

@distributedlock distributedlock changed the title feat(ktfmt): add ktfmt a Kotlin formatter from Facebook Incubator feat(ktfmt): add ktfmt a new Kotlin formatter from Facebook Incubator May 4, 2020
@nedtwigg
Copy link
Member

nedtwigg commented May 5, 2020

Great, thanks very much! Will be released by tomorrow (Tues) am PST.

@nedtwigg nedtwigg merged commit 1fa002e into diffplug:master May 5, 2020
@nedtwigg
Copy link
Member

nedtwigg commented May 5, 2020

Released in plugin-gradle 3.29.0, and plugin-maven 1.31.0

1 similar comment
@nedtwigg
Copy link
Member

nedtwigg commented May 5, 2020

Released in plugin-gradle 3.29.0, and plugin-maven 1.31.0

@distributedlock distributedlock deleted the feat/ktfmt branch May 6, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants