Improve JsonSimple exception messages #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goughy000
force-pushed
the
feature/json-format-cause
branch
from
0879899
to
bb80062
Compare
|
Thanks! Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, just a small PR to improve some of the exception messages when formatting fails in JsonSimple.
Previously the target exception was silently discarded, so you knew a file couldn't be formatted but was up to you to work out why. We now include the target exception as cause so it can appear in stack trace.
Also tweaked the message for the case where we can't determine if the root of the json tree is an object or array.