Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed module-info formatting in eclipse-jdt. #958

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Oct 4, 2021

Since JDT Core 3.13, the module-info formatting is distinguished by filename.
This PR still uses spotless-eclipse-base 3.5 and therefore requires JVM 11.

@fvgh fvgh requested a review from nedtwigg October 4, 2021 18:05
@fvgh
Copy link
Member Author

fvgh commented Oct 4, 2021

@nedtwigg
You are quite relaxed about code style when it comes to the _ext projects.
I would like your opinion on the backward compatibility.
I quickly checked the compliance with JDT core 3.13. It works fine. So we could provide backward compatible patches by releasing two versions (4.8.1 for JVM 8 and old base version / 4.9.0 for JVM 11).

On the other hand, nobody ever complained and I myslef are not planing to use Java modules without using at least Java 11.

Let me know what you prefer.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fvgh fvgh merged commit b2c5cd9 into main Oct 4, 2021
@fvgh fvgh deleted the eclipse-module-info branch October 4, 2021 18:42
@fvgh fvgh mentioned this pull request Oct 9, 2021
@nedtwigg
Copy link
Member

Published in plugin-gradle 5.17.0 and plugin-maven 2.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants