-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: buttons half-unclickable in the expanded details popup in Chrome #39
Comments
I can't recreate the issue, but I will change the approach on those elements to prevent that padding to affect those buttons. I can't apply your idea (which will in fact remove the padding) because I need the area to be scrollable. |
Yes, unfortunately, because the popup is "injected" onto the web page, it takes any CSS from that page that hasn't been overriden by me. At the time, I tried applying some "unsets" with "!important" to some properties of the popup, thus overriding whatever is set by the web page, but I must have missed some. |
I think Shadow DOM might be what you're looking for! https://developer.mozilla.org/docs/Web/API/Web_components/Using_shadow_DOM This reply from ChatGPT 4o should help if you want to use it: https://chatgpt.com/share/66e88d7e-e8f4-800a-a4bb-de7d02794116 |
Oh, it might actually be the solution. I will look into it, thanks! |
No, thank you for your hard work on this extension ^^ |
Perfect, that fixes it! Should I create an issue for using Shadow DOM to prevent future bugs related to the CSS of the parent page? |
Yes, go for it, it helps me remember it later. Thanks! |
Done -> #40 |
(Problem encountered on Windows 11, Chrome 128.0.6613.138)
The green area is unclickable, causing issues when clicking buttons on the right.
The problem is this property (attached to the expanded details popup that has class="sd-detailsPopup sd-focusPopup"), it seems there's an invisible vertical scrollbar that takes up 16.667 pixels on the right, and that's what causes issues.
It can be fixed by using this instead:
I'm not sure if this should be edited directly, of if you rely on some programming logic/some framework to generate this property, but given the info given, I think fixing this shouldn't be a too hard fix ^^
The text was updated successfully, but these errors were encountered: