Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add transmission content values test #1200

Merged
merged 2 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ public static CreateDialogCommand GenerateFakeDialog(
List<CreateDialogDialogAttachmentDto>? attachments = null,
List<CreateDialogDialogGuiActionDto>? guiActions = null,
List<CreateDialogDialogApiActionDto>? apiActions = null,
List<CreateDialogDialogActivityDto>? activities = null)
List<CreateDialogDialogActivityDto>? activities = null,
List<CreateDialogDialogTransmissionDto>? transmissions = null)
{
return GenerateFakeDialogs(
seed,
Expand All @@ -60,12 +61,12 @@ public static CreateDialogCommand GenerateFakeDialog(
attachments,
guiActions,
apiActions,
activities
activities,
transmissions
)[0];
}

public static List<CreateDialogCommand> GenerateFakeDialogs(
int? seed = null,
public static List<CreateDialogCommand> GenerateFakeDialogs(int? seed = null,
int count = 1,
Guid? id = null,
string? serviceResource = null,
Expand All @@ -86,7 +87,8 @@ public static List<CreateDialogCommand> GenerateFakeDialogs(
List<CreateDialogDialogAttachmentDto>? attachments = null,
List<CreateDialogDialogGuiActionDto>? guiActions = null,
List<CreateDialogDialogApiActionDto>? apiActions = null,
List<CreateDialogDialogActivityDto>? activities = null)
List<CreateDialogDialogActivityDto>? activities = null,
List<CreateDialogDialogTransmissionDto>? transmissions = null)
{
Randomizer.Seed = seed.HasValue ? new Random(seed.Value) : new Random();
return new Faker<CreateDialogCommand>()
Expand All @@ -108,6 +110,7 @@ public static List<CreateDialogCommand> GenerateFakeDialogs(
.RuleFor(o => o.ApiActions, _ => apiActions ?? GenerateFakeDialogApiActions())
.RuleFor(o => o.Activities, _ => activities ?? GenerateFakeDialogActivities())
.RuleFor(o => o.Process, f => process ?? GenerateFakeProcessUri())
.RuleFor(o => o.Transmissions, f => transmissions ?? GenerateFakeDialogTransmissions())
.Generate(count);
}

Expand All @@ -121,7 +124,8 @@ public static CreateDialogCommand GenerateSimpleFakeDialog(Guid? id = null)
attachments: [],
guiActions: [],
apiActions: [],
searchTags: []);
searchTags: [],
transmissions: []);
}

public static string GenerateFakeResource(Func<string?>? generator = null)
Expand Down
8 changes: 2 additions & 6 deletions src/Digdir.Tool.Dialogporten.GenerateFakeData/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ private static async Task RunAsync(Options options)
Randomizer.Seed = new Random(options.Seed);
var dialogs = DialogGenerator.GenerateFakeDialogs(
seed: new Randomizer().Number(int.MaxValue),
serviceResourceGenerator: () => MaybeGetRandomResource(options),
partyGenerator: () => MaybeGetRandomParty(options),
count: options.Count);
count: options.Count, serviceResourceGenerator: () => MaybeGetRandomResource(options), partyGenerator: () => MaybeGetRandomParty(options));
var serialized = JsonSerializer.Serialize(dialogs, JsonSerializerOptions);
Console.WriteLine(serialized);
return;
Expand Down Expand Up @@ -118,9 +116,7 @@ private static void ProduceDialogs(Options options, BlockingCollection<(int, Cre
var dialogsToGenerate = Math.Min(DialogsPerBatch, totalDialogs - dialogCounter);
var dialogs = DialogGenerator.GenerateFakeDialogs(
seed: new Randomizer().Number(int.MaxValue),
serviceResourceGenerator: () => MaybeGetRandomResource(options),
partyGenerator: () => MaybeGetRandomParty(options),
count: dialogsToGenerate).Take(dialogsToGenerate);
count: dialogsToGenerate, serviceResourceGenerator: () => MaybeGetRandomResource(options), partyGenerator: () => MaybeGetRandomParty(options)).Take(dialogsToGenerate);
foreach (var dialog in dialogs)
{
dialogQueue.Add((dialogCounter + 1, dialog), cancellationToken);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
using Digdir.Domain.Dialogporten.Application.Features.V1.ServiceOwner.Dialogs.Queries.Get;
using Castle.Core.Logging;
using Digdir.Domain.Dialogporten.Application.Features.V1.Common.Localizations;
using Digdir.Domain.Dialogporten.Application.Features.V1.ServiceOwner.Dialogs.Queries.Get;
using Digdir.Domain.Dialogporten.Application.Integration.Tests.Common;
using Digdir.Domain.Dialogporten.Domain.Dialogs.Entities.Transmissions;
using Digdir.Tool.Dialogporten.GenerateFakeData;
using FluentAssertions;
using static Digdir.Domain.Dialogporten.Application.Integration.Tests.UuiDv7Utils;
Expand Down Expand Up @@ -203,4 +206,70 @@ public async Task Can_Create_Dialog_With_UpdatedAt_And_CreatedAt_Being_Equal()
response.TryPickT0(out var success, out _).Should().BeTrue();
success.Should().NotBeNull();
}

[Fact]
public async Task Cannot_Create_Transmission_Without_Content()
{
// Arrange
var transmission = DialogGenerator.GenerateFakeDialogTransmissions(1)[0];
transmission.Content = null!;

var createDialogCommand = DialogGenerator.GenerateSimpleFakeDialog();
createDialogCommand.Transmissions = [transmission];

// Act
var response = await Application.Send(createDialogCommand);

// Assert
response.TryPickT2(out var validationError, out _).Should().BeTrue();
validationError.Should().NotBeNull();
validationError.Errors.Should().HaveCount(1);
validationError.Errors.First().ErrorMessage.Should().Contain("'Content' must not be empty");
}

oskogstad marked this conversation as resolved.
Show resolved Hide resolved
[Fact]
public async Task Cannot_Create_Transmission_Without_Content_Value()
{
// Arrange
var transmission = DialogGenerator.GenerateFakeDialogTransmissions(1)[0];
transmission.Content.Summary.Value = [];
transmission.Content.Title.Value = [];

var createDialogCommand = DialogGenerator.GenerateSimpleFakeDialog();
createDialogCommand.Transmissions = [transmission];

// Act
var response = await Application.Send(createDialogCommand);

// Assert
response.TryPickT2(out var validationError, out _).Should().BeTrue();
validationError.Should().NotBeNull();
validationError.Errors
.Count(e => e.PropertyName.Contains(nameof(createDialogCommand.Content)))
.Should()
.Be(2);
}

oskogstad marked this conversation as resolved.
Show resolved Hide resolved
[Fact]
public async Task Cannot_Create_Transmission_With_Empty_Content_Localization_Values()
{
// Arrange
var transmission = DialogGenerator.GenerateFakeDialogTransmissions(1)[0];
transmission.Content.Summary.Value = [new LocalizationDto { LanguageCode = "nb", Value = "" }];
transmission.Content.Title.Value = [new LocalizationDto { LanguageCode = "nb", Value = "" }];

var createDialogCommand = DialogGenerator.GenerateSimpleFakeDialog();
createDialogCommand.Transmissions = [transmission];

// Act
var response = await Application.Send(createDialogCommand);

// Assert
response.TryPickT2(out var validationError, out _).Should().BeTrue();
validationError.Should().NotBeNull();
validationError.Errors
.Count(e => e.PropertyName.Contains(nameof(createDialogCommand.Content)))
.Should()
.Be(2);
}
}
oskogstad marked this conversation as resolved.
Show resolved Hide resolved
Loading