Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use data from events, not from db #455

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

oskogstad
Copy link
Collaborator

No description provided.

@oskogstad oskogstad changed the title Use data from events fix: Use data from events, not from db Feb 18, 2024
Copy link

sonarcloud bot commented Feb 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@oskogstad oskogstad marked this pull request as ready for review February 18, 2024 21:39
@arealmaas
Copy link
Collaborator

SonarCloud maser litt om duplication her nå da

@oskogstad
Copy link
Collaborator Author

SonarCloud maser litt om duplication her nå da

Ja, det ble en del ekstra new-ing av CloudEvents, tror ikke om det er verdt det å begynne å komplisere til med flere base-klasser/arv for undergrupper av events.
Bryter litt DRY, men beholder litt KISS? 🙈

@oskogstad oskogstad merged commit 469c606 into main Feb 19, 2024
5 of 6 checks passed
@oskogstad oskogstad deleted the fix/dont-fetch-event-data-from-database branch February 19, 2024 15:21
arealmaas pushed a commit that referenced this pull request Feb 28, 2024
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2024-02-28)


### Features

* Add element count to eu list dto
([#414](#414))
([934fa93](934fa93))
* Add purge functionallity separate from soft delete.
([#483](#483))
([1349efb](1349efb))
* Add SeenBy per user
([#368](#368))
([c68db9e](c68db9e))
* **azure:** parameterize SKUs
([#364](#364))
([9c27c74](9c27c74))
* change format of party identifier
([#376](#376))
([27e6744](27e6744)),
closes [#220](#220)
* Container app revision verification on deploy
([#392](#392))
([db13a89](db13a89))
* Slack notifier IaC
([#341](#341))
([80c3579](80c3579))


### Bug Fixes

* 412 status on multiple requests without revision header
([#427](#427))
([047cf71](047cf71))
* add APIM base uri for dialogporten
([948b9a4](948b9a4))
* add apim base uri for staging
([#451](#451))
([580d946](580d946))
* add base uri for web api
([#425](#425))
([0aa941b](0aa941b))
* add correct APIM base uri for dialogporten
([713771a](713771a))
* add correct baseuri for altinn events
([#496](#496))
([74940ab](74940ab))
* Add null checks, set lists to empty if null
([#434](#434))
([f264aec](f264aec))
* **azure:** fix postgresql auth config
([#357](#357))
([4a4757f](4a4757f))
* **azure:** remove default value for KEY_VAULT_SOURCE_KEYS
([#418](#418))
([b0d74e8](b0d74e8))
* **azure:** remove default values in params and ensure secure on params
([#415](#415))
([94b9885](94b9885))
* **azure:** rename and fix outputs and pass correct secrets
([#416](#416))
([68f0c8b](68f0c8b))
* build errors for 8.0.200
([#440](#440))
([b133f8f](b133f8f))
* Check Content for null, use DependentRules, disallow empty
localization values
([#413](#413))
([894644a](894644a))
* Correct params for revision verification
([#405](#405))
([4b98348](4b98348))
* Do not allow empty content
([#436](#436))
([a083544](a083544))
* do not prefix swagger document in development
([#491](#491))
([e330ce3](e330ce3))
* remove path to swagger json
([fe1e770](fe1e770))
* rename migration job
([#423](#423))
([3897db2](3897db2))
* restrict container apps to apim ip
([#448](#448))
([1a1f3ad](1a1f3ad))
* Return 410 Gone when updating deleted dialog
([#464](#464))
([2498b0a](2498b0a))
* set base path for swagger json ui
([476fdca](476fdca))
* set base url for swagger json
([#447](#447))
([2161066](2161066))
* shorten secret name for container app job
([#422](#422))
([09b2f30](09b2f30))
* try echoing pgpassword in migration job🤫
([#419](#419))
([fe673a3](fe673a3))
* Use data from events, not from db
([#455](#455))
([469c606](469c606))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants