[DO NOT MERGE] fix mapbox token issue #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
force-pushed
the
v5.6.3/fix-mapbox-token
branch
from
7e14548
to
ccc7c68
Compare
|
do i need to disable any signing/notarization steps in the electron-build configuration? |
gmaclennan
approved these changes
May 13, 2024
achou11
force-pushed
the
v5.6.3/fix-mapbox-token
branch
from
ccc7c68
to
3748f18
Compare
|
Closing this since release tag has been pushed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #756
Making this a draft so that it doesn't accidentally get merged. PR is just for easier reviewing
Note that this branches off the latest released tag (v5.6.2).
After review, I can squash down the atomic commits and create a tagged commit on this branch to trigger the publishing flow.
Notes:
a
.envfile containing aMAPBOX_ACCESS_TOKENentry is now necessary for local developmentthe setup for reading the token is quite convoluted because of the nature of the file that holds that value. I added a lengthy comment where appropriate to provide proper details, which stem from the murky boundary between renderer and main process code in Electron.
I've added a secret to this repository called
MAPBOX_ACCESS_TOKENthat holds the new tokendisables autoupdate publishing for S3 (see Autoupdater is not working when trying to install 5.6.2 #750 for more context)
updates the development node version to v14 to fix issues with running the
electron-buildercli (mainly needed for testing/debugging). we use node v14 for CI so i figured this should be okay to do, despite our Electron version running v12