Skip to content

Commit

Permalink
Fix some more lint warnings (#88)
Browse files Browse the repository at this point in the history
* Correct delegate is now checked as responder for auth callback (Guest Consent) (#73)

* DIGI-14961 DigiMe SDK offers Guest consent / native authentication choice to the user (#71)

* DIGI-14961 DigiMe SDK offers Guest consent / native authentication choice to the user

* DIGI-14961 documentation update

* DIGI-15242 :: Added means of quickly viewing share receipts in the digi.me app. (#74)

* Lowercased deep link parameters for consistency

* Added missing description. Silenced 'passing a null' warning

* Swapped open URL call to use system one.

* DIGI-14993 Ability to push data to Postbox (#78)

* DIGI-14993 Ability to push data to Postbox

* Postbox documentation read.me file update

* DIGI-15235 Stage one of SDK changes to support raw data. (#79)

* Update podspec version to 2.5.0 (#80)

* Resolve lint issues (#82)

* Remove deprecated .swift-version file

* Update Repository after changing core method

* Fix nullable lint warning (#85)

* Fix lint warnings (#87)
  • Loading branch information
michaeleustace authored and hamiltonalex committed Jun 3, 2019
1 parent 90d46d1 commit 0e5728e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions DigiMeSDK.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ Pod::Spec.new do |s|
'DigiMeSDK/Core/Classes/Security/DME*.h',
'DigiMeSDK/Core/Classes/DMEAuthorizationManager.h',
'DigiMeSDK/Core/Classes/DMEClient+Private.h',
'DigiMeSDK/Core/Classes/CASession+Private.h',
'DigiMeSDK/Core/Classes/Entities/CASession+Private.h',
'DigiMeSDK/Core/Classes/DMEAPIClient+Private.h'
end

s.subspec 'Postbox' do |ss|
ss.source_files = "DigiMeSDK/Postbox/Classes/**/*.{h,m,swift}"
ss.frameworks = "Foundation", "UIKit"
ss.private_header_files = 'DigiMeSDK/Core/Classes/DMEPostboxManager.h'
ss.private_header_files = 'DigiMeSDK/Postbox/Classes/DMEPostboxManager.h'
ss.xcconfig = { 'OTHER_CFLAGS' => '$(inherited) -DDigiMeSDKPostbox' }
ss.dependency "DigiMeSDK/Core"
end
Expand Down
1 change: 0 additions & 1 deletion DigiMeSDK/Core/Classes/Network/DMEAPIClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ - (void)dealloc
- (void)cancelAllOperations
{
[self.queue cancelAllOperations];
self.queue = nil;

for (NSOperation* o in [[NSOperationQueue mainQueue] operations])
{
Expand Down
2 changes: 1 addition & 1 deletion DigiMeSDK/Core/Classes/Network/DMERequestFactory.m
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ - (NSURLRequest *)pushRequestWithPostboxId:(NSString *)postboxId payload:(NSData

[body appendData:[[NSString stringWithFormat:@"--%@--\r\n", boundary] dataUsingEncoding:NSUTF8StringEncoding]];
[request setHTTPBody:body];
NSString *postLength = [NSString stringWithFormat:@"%lu", [body length]];
NSString *postLength = [NSString stringWithFormat:@"%lu", (unsigned long)[body length]];
[request setValue:postLength forHTTPHeaderField:@"Content-Length"];

return request;
Expand Down
2 changes: 1 addition & 1 deletion DigiMeSDK/Postbox/Classes/DMEClient+Postbox.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ NS_ASSUME_NONNULL_BEGIN
@param completion PostboxCreationCompletionBlock
*/
- (void)createPostboxWithCompletion:(PostboxCreationCompletionBlock)completion;
- (void)createPostboxWithCompletion:(nullable PostboxCreationCompletionBlock)completion;

/**
Pushes data to user's Postbox.
Expand Down

0 comments on commit 0e5728e

Please sign in to comment.