Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGI-20955 Ongoing Postbox support #199

Merged

Conversation

michaeleustace
Copy link
Contributor

  • Add new OngoingPostbox class and related data push/authorisation functions.
  • Refactor common OAuth functions into new OAuth service.
  • More config options are now common between push and pull so these have been moved to base class.
  • Fix tests
  • Update Swift example app to use Ongoing Postbox. Also refactored the welcome screen and split out private sharing examples into separate buttons.
  • Have checked that all push and pull options work.
  • Ensured that all pull/push functions complete on main thread
  • Fixed some flow logic errors.
  • Split action for opening digi.me app into host and path where necessary as the URLs for actions with 2 parts (e.g. postbox/create) were not being formed correctly (e.g. ://postbox%2Fcreate instead of ://postbox/create meaning that digi.me app wasn't routing the request correctly.

@michaeleustace michaeleustace changed the title Ongoing Postbox support DIGI-20955 Ongoing Postbox support Feb 10, 2021
Copy link
Contributor

@hamiltonalex hamiltonalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the README.md file for the new Ongoing Postbox option. It will help our customers to try it and use...

@michaeleustace michaeleustace changed the base branch from master to epic/DIGI-17598_cyclic_postbox February 18, 2021 08:22
@michaeleustace
Copy link
Contributor Author

Could you please update the README.md file for the new Ongoing Postbox option. It will help our customers to try it and use...

I have changed this PR to merge into epic branch. Will create separate PR for documentation in due course.

@hamiltonalex hamiltonalex merged commit 54efa47 into epic/DIGI-17598_cyclic_postbox Feb 19, 2021
@hamiltonalex hamiltonalex deleted the story/DIGI-20955_cyclic_postbox branch February 19, 2021 16:05
hamiltonalex pushed a commit that referenced this pull request Mar 5, 2021
* DIGI-20955 Ongoing Postbox support (#199)

* Fix some flow errors

* WIP

* Split common ongoing OAuth flow into separate class: DMEOAuthService

* Move some more functions to OAuthService

* Ensure that all pull and push client callbacks occur on main thread.

* OAuthToken and OngoingPostbox now conform to NSSecureCoding.

* Split action for opening digi.me app into host and path where necessary.

* Bump cyclic endpoints to v1.4

* Add workspace checks

* Update new SDK functions to complete on main thread

* Return an SDK error if try to use ongoing postbox with one-off contract

* Update Swift demo to include ongoing postbox example

* Update tests

* Oops. Wasn't actually pushing data using oauth token!!

* DIGI-21401 Update examples app to include contacts and private keys (#201)

* Add example contracts for private sharing

* Add example contracts and p12s

* Fix error when decoding ongoing postbox

* Store ongoing postboxes in example.

* Add instruction for user to try relaunching app after first ongoing postbox push

* Update ongoing private sharing contract.

Added info about each contract in the code.

* Fix broken CA pull examples.

* DIGI-21393 Ongoing Postbox documentation (#200)

* Add Ongoing Postbox documentation

* Add migration tips for breaking code

* Update Postbox docs with breaking changes and reference ongoing gpostbox

* Fix scope documentation to refer to DMESessionOptions

* Fix spelling

* Fix broken link in getting started

* Remove unnecessary docsets

* Ignore docsets in future and any intermediary files for documentation generation

* Split sources & scripts for documentation generation into seperate folder

* Add documentation for Swift files

* Update readmes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants