A quick fix to our social object Post unit test #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same field in different JFS files
michaeleustace
suggested changes
Dec 19, 2018
| @@ -56,7 +56,9 @@ public class Post: NSObject, BaseObjectDecodable { | |||
| public let likeCount: Int | |||
| public let links: [Link]? | |||
| public let longitude: Double | |||
| public let originalPostIdentifier: String? | |||
| public var originalPostIdentifier: String? { | |||
| return String(describing: originalPostIdentifierRaw) | |||
There was a problem hiding this comment.
This (and the other functions using String(describing:)) should check whether the raw value is nil first, otherwise the string returned is "nil"!
i.e.
guard let x = x else {
return nil
}
return String(describing: x)
michaeleustace
approved these changes
Dec 19, 2018
hamiltonalex
pushed a commit
that referenced
this pull request
Feb 14, 2019
* Post object can now handle different types for original post identifier (#54) * Added guest consent podspec * Updated quark to work with scope changes. * Swapped Brotli for GZIP compression. * Swapped Brotli for GZIP compression. (#55) * Version increment to add GZIP support and timing tool support (#56) * DIGI-13285 load new environments dynamically from the documents folder (#57) * DIGI-13285 load new environments dynamically from the documents folder * additional null check to be cconsistent with the other code * Private CASession header for core. * Reflected changes for postbox. * DIGI-13286, DIGI-13289, DIGI-13290 - Filter out specific values into the Session dictionary (#59) * DIGI-13286, DIGI-13289, DIGI-13290 - Filter out specific values into the Session dictionary * Remove obsolete vars * Quick doc fix * Postbox included in the podspec * Updated SDK to remove support for CAFileObject. Updated Default p12 + contract combo * Updated p12 + contract combo in Swift example * Updated Documentation to clarify change to the delegate pattern. (#64) * Updated Documentation * Link fix * Update copyright date * Updated podspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.