Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https to access central.maven.org #4056

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Use https to access central.maven.org #4056

merged 2 commits into from
Jan 15, 2020

Conversation

aherrmann-da
Copy link
Contributor

Now strictly required by maven see https://support.sonatype.com/hc/en-us/articles/360041287334

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann
use https for maven
42938ea 
CHANGELOG_BEGIN
CHANGELOG_END
@aherrmann-da aherrmann-da marked this pull request as ready for review January 15, 2020 16:47
stefanobaghino-da
stefanobaghino-da approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

cocreature
cocreature approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

@mergify mergify bot merged commit 0c4f9d7 into master Jan 15, 2020
@mergify mergify bot deleted the https branch January 15, 2020 17:41
stefanobaghino-da added a commit that referenced this pull request Jan 16, 2020
@stefanobaghino-da
Return to unpatched rules_scala
6691fbb 
The issue solved with a patch by

#4056

Has been solved upstream by

bazelbuild/rules_scala#920

CHANGELOG_BEGIN
CHANGELOG_END
@stefanobaghino-da stefanobaghino-da mentioned this pull request Jan 16, 2020
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Jan 16, 2020
@stefanobaghino-da @mergify
Return to unpatched rules_scala (#4065)
cd5ecab 
The issue solved with a patch by

#4056

Has been solved upstream by

bazelbuild/rules_scala#920

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanobaghino-da stefanobaghino-da stefanobaghino-da approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aherrmann-da @cocreature @stefanobaghino-da @aherrmann