Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update endpoint seeded by us #341

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update endpoint seeded by us #341

merged 2 commits into from
Dec 12, 2024

Conversation

kena-SL
Copy link
Contributor

@kena-SL kena-SL commented Dec 11, 2024

Data Template

Ticket

  • Link:

Type

  • New data
  • Data monitoring
  • Data fix

Data updated:

  • Dataset: CA & CAD

Expected outcome (if relevant):

  • New endpoint & source & lookups
  • New endpoint & source
  • New lookups
  • Retired old endpoint & source

Additional information:

  • Endpoint path updated

Checklist:

  • Have checked no previous endpoints to retire
  • Have validated (with check or endpoint checker)
  • Have checked for any geo duplicates (if CA data)
  • Have updated entity-organisation.csv (if CA data)
  • Have checked expected number of lookups

AlexanderVerheecke
AlexanderVerheecke approved these changes Dec 11, 2024
View reviewed changes
Copy link

@AlexanderVerheecke AlexanderVerheecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

averheecke-tpx
averheecke-tpx approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@averheecke-tpx averheecke-tpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kena-SL kena-SL merged commit 5a45fba into main Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averheecke-tpx averheecke-tpx averheecke-tpx approved these changes

@AlexanderVerheecke AlexanderVerheecke AlexanderVerheecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kena-SL @AlexanderVerheecke @averheecke-tpx