Skip to content

Commit

Permalink
content changes re alex feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
GeorgeGoodall committed Dec 4, 2024
1 parent fb737e4 commit 0883bc1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/middleware/common.middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ export function getErrorSummaryItems (req, res, next) {
if (issue.reference && !specialIssueTypeCases.includes(issue.issue_type)) {
inString = ` in entity with reference ${issue.reference}`
} else if (issue.line_number) {
inString = ` in row ${issue.line_number}`
inString = ` on row ${issue.line_number}`
}
return {
html: performanceDbApi.getTaskMessage({ issue_type: issueType, num_issues: 1, field: issueField }) + inString,
Expand Down
4 changes: 2 additions & 2 deletions src/middleware/entryIssueDetails.middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const prepareEntry = (req, res, next) => {
fields: [
{
key: {
text: 'Endpoint'
text: 'Endpoint URL'
},
value: {
html: `<a href='${resources[0].endpoint_url}'>${resources[0].endpoint_url}</a>`
Expand All @@ -100,7 +100,7 @@ export const prepareEntry = (req, res, next) => {
},
{
key: {
text: 'Line number'
text: 'Row'
},
value: {
html: issue.line_number.toString()
Expand Down
4 changes: 2 additions & 2 deletions test/unit/middleware/entryIssueDetails.middleware.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ describe('entryIssueDetails.middleware.test.js', () => {
title: 'entry: 1',
fields: [
{
key: { text: 'Endpoint' },
key: { text: 'Endpoint URL' },
value: { html: '<a href=\'https://example.com\'>https://example.com</a>' },
classes: ''
},
{
key: { text: 'Line number' },
key: { text: 'Row' },
value: { html: '2' },
classes: ''
},
Expand Down

0 comments on commit 0883bc1

Please sign in to comment.