Change the URL exists logic to return false only when it's 404

digital-land · Dec 12, 2024 · 8b1ba74 · 8b1ba74
1 parent 38cdfec
commit 8b1ba74
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/controllers/submitUrlController.js b/src/controllers/submitUrlController.js
@@ -157,8 +157,9 @@ class SubmitUrlController extends UploadController {
     if (!response) {
       return false
     }
+
     try {
-      return (response.status >= 200 && response.status < 300) || response.status === 400 // need to add 400 as some servers return 400 for head requests
+      return response.status !== 404 // Allow everything except 404, we cannot be sure what the server will return for HEAD requests
     } catch (err) {
       logger.warn(err)
       return true

diff --git a/test/unit/submitUrlController.test.js b/test/unit/submitUrlController.test.js
@@ -188,8 +188,8 @@ describe('SubmitUrlController', async () => {
         expect(SubmitUrlController.isUrlAccessible({ status: 200 })).toBe(true)
       })
 
-      it('should return false for URLs that exist with a 3XX status code', async () => {
-        expect(SubmitUrlController.isUrlAccessible({ status: 301 })).toBe(false)
+      it('should return true for URLs that exist with a 3XX status code', async () => {
+        expect(SubmitUrlController.isUrlAccessible({ status: 301 })).toBe(true)
       })
 
       it('should return false for URLs that exist with a 4XX status code', async () => {