Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content and styling on check tool playback page #571

Closed
CharliePatterson opened this issue Oct 22, 2024 · 9 comments
Closed

Update content and styling on check tool playback page #571

CharliePatterson opened this issue Oct 22, 2024 · 9 comments
Assignees
Labels
Spill over Identifies tickets not completed in sprint and have been carried over into next sprint

Comments

@CharliePatterson
Copy link
Contributor

CharliePatterson commented Oct 22, 2024

Context:

  • We have iterated on the layout, styling and content of the data playback and errors elsewhere in the service (on the dataset details page and dataset issues pages).
  • The styling and content of the check tool now is out of sync with the rest of the service.

Acceptance criteria:

  • As a data provider, when I'm on the playback page of the check tool, the styling and content of the pages matches the latest designs:

05a results
05b errors

@alextea
Copy link
Contributor

alextea commented Oct 23, 2024

Links to the updated designs in the prototype:

Errors page
Results page

@digital-land digital-land deleted a comment from alextea Oct 23, 2024
@CharliePatterson CharliePatterson moved this from Needs refinement to Sprint backlog in Submit and update planning data service Oct 23, 2024
@GeorgeGoodall-GovUk
Copy link
Contributor

GeorgeGoodall-GovUk commented Oct 28, 2024

just a note, the new table styling was implemented in my table branch. probably best I pick this up eventually as i can just cherry pick that code
table should have been implemented so the other tasks just need completing

@rosado
Copy link
Collaborator

rosado commented Oct 31, 2024

Which page is the 'playback page'? Seems like the templates to update are the 'errors.html' and 'no-errors.html'

@CharliePatterson
Copy link
Contributor Author

@rosado rosado self-assigned this Oct 31, 2024
@rosado rosado moved this from In Peer Review to In Development in Submit and update planning data service Nov 7, 2024
@rosado
Copy link
Collaborator

rosado commented Nov 7, 2024

@CharliePatterson for the errors page, the error summary items look like links what are they supposed to link to?

@rosado rosado assigned rosado and unassigned GeorgeGoodall-GovUk Nov 7, 2024
rosado added a commit that referenced this issue Nov 7, 2024
@CharliePatterson
Copy link
Contributor Author

Ah - I don't think they should be links. We use that styling on the entity-level issues pages, so that users can click on the issue and be shown the specific entity, though I don't think we need to do that in the table, as they can scroll through each one. It'd be good to check with @alextea though on the intended interaction here.

@alextea
Copy link
Contributor

alextea commented Nov 13, 2024

Sorry — I didn't see this comment. Could we remove the links and change the text in the error summary to use these error messages: https://github.com/digital-land/submit/blob/main/src/content/fieldIssueMessages.csv

@rosado
Copy link
Collaborator

rosado commented Nov 14, 2024

@alextea re: error messages - short answer is no, as in the comment on #640

@neilfwar
Copy link

neilfwar commented Nov 20, 2024

will close and @rosado to add new ticket to backlog for what alex is asking

@CharliePatterson CharliePatterson moved this from Done to Ready for release in Submit and update planning data service Nov 20, 2024
@DilwoarH DilwoarH moved this from Ready for release to Done in Submit and update planning data service Nov 21, 2024
@neilfwar neilfwar added the Spill over Identifies tickets not completed in sprint and have been carried over into next sprint label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spill over Identifies tickets not completed in sprint and have been carried over into next sprint
Projects
Development

No branches or pull requests

6 participants