-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent way of displaying numerical data/dates in table component #679
Comments
Let's remove the The GOVUK Design system documentation also suggests using this class only when comparing columns of numbers:
ref: https://design-system.service.gov.uk/components/table/#numbers-in-a-table What do you think @alextea? |
Things that need to be done if we decide to remove the functionality:
|
This makes all columns consistent. The GOVUK Design system documentation also suggests using this class only when comparing columns of numbers: When comparing columns of numbers, align the numbers to the right in table cells. #679
This makes all columns consistent. The GOVUK Design system documentation also suggests using this class only when comparing columns of numbers: When comparing columns of numbers, align the numbers to the right in table cells. #679
What
Numerical and dates columns in tables should have
govuk-table__cell--numeric
class on them.Why
govuk standard.
Background
As pointed out by @alextea in a comment
We should put the appropriate class on numerical data and dates in our table component. Right now the use is inconsistent (e.g. putting the class on a cell vs. a column) and sometimes added to cells with non-number type (example, see the 'reference' column which contains data that looks like a number, but also alphanumerical strings).
The text was updated successfully, but these errors were encountered: