Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way we get boundary GeoJSON #699

Closed
DilwoarH opened this issue Nov 27, 2024 · 0 comments · Fixed by #718
Closed

Change the way we get boundary GeoJSON #699

DilwoarH opened this issue Nov 27, 2024 · 0 comments · Fixed by #718
Assignees
@DilwoarH
Milestone
Q3 Improving data...

Comments

@DilwoarH
Copy link
Contributor

DilwoarH commented Nov 27, 2024 •
edited
Loading

What

Change the way we get boundary GeoJSON.

Use the following steps:

  1. Get Local authority -> https://www.planning.data.gov.uk/entity.json?dataset=local-authority&reference=BST
  2. From the JSON field within the response to get the local-planning-authority reference
  3. Get GeoJSON using this reference: https://www.planning.data.gov.uk/entity.geojson?reference=E60000290

Steps 1 & 2 may already be done in the backend so investigate this first.

Why

The current method is "looking for data within the LAD boundary, so hit and miss". The new method allows us to have a more accurate result.

More info can be found here: https://tpximpact.slack.com/archives/C04T2E0CZ0D/p1732636759514689
@DilwoarH DilwoarH self-assigned this Nov 27, 2024
@DilwoarH DilwoarH converted this from a draft issue Nov 27, 2024
@CharliePatterson CharliePatterson mentioned this issue Dec 3, 2024
Closed
@CharliePatterson CharliePatterson moved this from Ready for refinement to Refined in Submit and update planning data service Dec 3, 2024
@CharliePatterson CharliePatterson moved this from Refined to Eng sprint backlog in Submit and update planning data service Dec 3, 2024
@DilwoarH DilwoarH moved this from Eng sprint backlog to In Development in Submit and update planning data service Dec 4, 2024
@DilwoarH DilwoarH mentioned this issue Dec 5, 2024
Merged
11 tasks
@DilwoarH DilwoarH linked a pull request Dec 5, 2024 that will close this issue
Create boundary API #718
Merged
11 tasks
@DilwoarH DilwoarH moved this from In Development to Code review & QA in Submit and update planning data service Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Code review & QA to Done in Submit and update planning data service Dec 10, 2024
@DilwoarH DilwoarH moved this from Done to Ready for release in Submit and update planning data service Dec 10, 2024
@DilwoarH DilwoarH moved this from Ready for release to Done in Submit and update planning data service Dec 11, 2024
@neilfwar neilfwar added this to the Q3 Improving data quality milestone Dec 12, 2024
rosado added a commit that referenced this issue Dec 12, 2024
@rosado
broken endpoints ux changes
4928e52 
issue #699

Changes how/where endpoints are displayed.

- The dataset overview page highlights endpoints with 'Error' status
and provides links to the endpoint error page.
- The dataset task list now includes an item for each 'Error'-ing
endpoint
- The task count includes the 'Error'-ing endpoint
- the `latest_200_date` template param no longer includes the time - it
made no sense
- updated the middleware chain for dataset task list to no longer
conditionally include the endpoint error page
- made logging in `extractJsonFieldFromEntities` less noisy
rosado added a commit that referenced this issue Dec 12, 2024
@rosado
broken endpoints ux changes
536ac60 
issue #699

Changes how/where endpoints are displayed.

- The dataset overview page highlights endpoints with 'Error' status
and provides links to the endpoint error page.
- The dataset task list now includes an item for each 'Error'-ing
endpoint
- The task count includes the 'Error'-ing endpoint
- the `latest_200_date` template param no longer includes the time - it
made no sense
- updated the middleware chain for dataset task list to no longer
conditionally include the endpoint error page
- made logging in `extractJsonFieldFromEntities` less noisy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DilwoarH DilwoarH

Labels
None yet
Projects
Submit and update planning data service
Status: Done
Milestone
Q3 Improving data quality
Development

Successfully merging a pull request may close this issue.

Create boundary API digital-land/submit
2 participants
@DilwoarH @neilfwar