LPA dashboard increment #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve into separate file for easier testing
Feat/dashboard
Feat/get real data from datasette for the dashboard
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
rosado
reviewed
Jul 31, 2024
| if (!name) { | ||
| // throw new Error(`Can't find a name for ${slug}`) | ||
| // ToDo: work out what to do here? potentially update it with data from datasette | ||
| logger.error(`can't find a name for ${slug}`) |
There was a problem hiding this comment.
Good call, we shouldn't blow up, the slug is (in theory) readable, so is't ok to proceed. But please lower the level of the statement to warning (with error reserved pretty much for "we just need to crash because things got so bad")
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
rosado
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://github.com/orgs/digital-land/projects/7/views/9?pane=issue&itemId=72093714
this ticket is to merge staging into main, the diff between staging and main mostly consists of the addition of the lpa dashboard
note that all this code has been previously peer reviewed to get into the staging branch