Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/step by step/correct data #222

Merged
merged 19 commits into from
Aug 6, 2024
Merged

Conversation

GeorgeGoodall
Copy link
Contributor

@GeorgeGoodall GeorgeGoodall commented Aug 6, 2024

Ticket: #209

before this ticket is reviewed we should merge in: #221

This ticket makes sure the step-by-step/get-started template is populated with the correct params

@GeorgeGoodall GeorgeGoodall marked this pull request as ready for review August 6, 2024 14:27
Copy link
Collaborator

@rosado rosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

As an aside: Is there a static list of LPAs so that we could validate the lpa param easily, and maybe provide a useful error?

@GeorgeGoodall GeorgeGoodall merged commit d407173 into staging Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants