Add 'manage' start page #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just updated this PR to merge into staging instead of main |
rosado
force-pushed
the
rosado/start-page
branch
from
2d8adcf to
892661d
Compare
rosado
force-pushed
the
rosado/start-page
branch
from
892661d to
b1e04c8
Compare
rosado
force-pushed
the
rosado/start-page
branch
from
0ff5b3d to
a02e9cd
Compare
Use 'Submit and update your planning data' as full service name.
Seems like we're passing 'serviceName' to nunjucks in a lot of places for no reason - we already use `getFullServiceName()` to map a short service name (called 'serviceType' in the templates) to a full service name. Switching to a map of service names allows us to skip passing the service name explicitly.
rosado
force-pushed
the
rosado/start-page
branch
from
2c5c320 to
2e00127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Introduces new start page under
/managepath.Additionally, adds a 'serviceNames' (notice the plural) section to the config (and config schema). This is because we have three different services in the project (number arrived at by counting distinct values of 'serviceType' in the templates). The serviceType determines the title via use of
getFullServiceName()function. That function was updated to use the new 'serviceNames' mapping. In effect it's possible to remove the 'serviceName' parameter from a number of places.