Add FIXMEs for implementing ProblemDetails return values.

digitalbazaar · Dec 15, 2024 · 445f296 · 445f296
1 parent 6969a7e
commit 445f296
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 8 deletions.
diff --git a/lib/http.js b/lib/http.js
@@ -72,19 +72,19 @@ export async function addRoutes({app, service} = {}) {
     asyncHandler(async (req, res) => {
       const {config} = req.serviceObject;
 
+      const {
+        options = {},
+        verifiableCredential: credential,
+      } = req.body;
+
       let response;
       try {
-        const {
-          options = {},
-          verifiableCredential: credential,
-        } = req.body;
-
         const {checks} = options;
         _validateChecks({checks});
         const result = await verifyCredential({config, credential, checks});
-        response = _createResponse({credential, result, checks});
+        response = _createResponse({options, credential, result, checks});
       } catch(e) {
-        response = _createResponse({error: e});
+        response = _createResponse({options, error: e});
       }
 
       if(response.verified) {
@@ -185,7 +185,25 @@ function _validateChecks({checks}) {
   }
 }
 
-function _createResponse({credential, result, challengeUses, error, checks}) {
+function _createResponse({
+  options, credential, result, challengeUses, error, checks
+}) {
+  // FIXME: return these additional fields:
+  /*
+  {
+    "verified": false,
+    "document": verifiableCredential,
+    "mediaType": "application/vc",
+    "controller": issuer,
+    "controllerDocument": didDocument,
+    // FIXME: return only if `options.returnProblemDetails`
+    "warnings": [ProblemDetails],
+    "errors": [ProblemDetails]
+    // FIXME: return only if `options.returnCredential`
+    "credential": <credential w/o proof>
+  }
+  */
+
   result = result || {verified: false, error};
 
   let response;

diff --git a/schemas/bedrock-vc-verifier.js b/schemas/bedrock-vc-verifier.js
@@ -235,6 +235,18 @@ export function verifyCredentialBody() {
           envelopedVerifiableCredential
         ]
       }
+      // FIXME: add `returnCredential`
+      // FIXME: add `returnProblemDetails`
+      /*
+{
+  "verified": false,
+  "document": verifiableCredential,
+  "mediaType": "application/vc",
+  "controller": issuer,
+  "controllerDocument": didDocument,
+  "warnings": [ProblemDetails],
+  "errors": [ProblemDetails]
+}*/
     }
   };
 }