Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check BitstringStatusList credentialStatus. #81

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Check BitstringStatusList credentialStatus. #81

merged 4 commits into from
Nov 7, 2024

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Nov 6, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (9eb6950) to head (89105f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   79.76%   79.85%   +0.08%     
==========================================
  Files          12       12              
  Lines        1888     1896       +8     
==========================================
+ Hits         1506     1514       +8     
  Misses        382      382              
Files with missing lines Coverage Δ
lib/di.js 100.00% <100.00%> (ø)
lib/status.js 85.18% <100.00%> (+2.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb6950...89105f3. Read the comment docs.

@@ -57,7 +57,7 @@ export async function verifyPresentation({
documentLoader: await createDocumentLoader({config}),
suite: createSuites(),
unsignedPresentation: !checks.includes('proof'),
checkStatus
checkStatus: _checkStatus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs the same checkStatus wrapper as above in verifyCredential. Probably need more presentation related tests.

Copy link
Member Author

@dlongley dlongley Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could change it to that, but that would I think change the existing behavior. It's probably more consistent to do it that way and perhaps even a bug that it wasn't behaving that way before, but I'd rather avoid changing it right now in this PR.

@dlongley dlongley merged commit 1040f95 into main Nov 7, 2024
4 checks passed
@dlongley dlongley deleted the check-status branch November 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants