Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained uid-number package with passwd-user. #124

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Oct 14, 2024

I would also like to update the serialize-error package. It has a new major version with this changelog that I don't expect to affect us:

https://github.com/sindresorhus/serialize-error/releases/tag/v11.0.0

@mattcollier, please let me know if you think I can roll that update in.

EDIT: I manually tested the new username => UID code path here. We don't have a good built-in test for this -- and I'm not sure how to write one that will work across systems either (not taking on figuring that out either at the moment).

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (099a22a) to head (9ecc9a3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/loggers/fileLogger.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   81.45%   81.43%   -0.02%     
==========================================
  Files          10       10              
  Lines        1941     1939       -2     
==========================================
- Hits         1581     1579       -2     
  Misses        360      360              
Files with missing lines Coverage Δ
lib/loggers/fileLogger.js 82.14% <50.00%> (-0.32%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099a22a...9ecc9a3. Read the comment docs.

@dlongley dlongley merged commit 6ffa482 into main Oct 15, 2024
4 checks passed
@dlongley dlongley deleted the update-deps branch October 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants