Add test vectors and fix P-384 proofs. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlehn
reviewed
Aug 26, 2024
| 'Either "verificationMethod" or "signer" with "algorithm" must be ' + | ||
| 'passed to cryptosuite to determine hash algorithm.'); | ||
| } | ||
| const algorithm = keyAlgorithm === 'P-256' ? 'SHA-256' : 'SHA-384'; |
There was a problem hiding this comment.
Does this (and the sha.js file) need to be more explicit about hashes it handles and otherwise fail? If you had a P-521 verificationMethod, would the code get here with that keyAlgorithm and pick the wrong hash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.